Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Test TestGitHubFolderCheckoutOptimization/custom_checkout_keeps_github_sparse failed because its expectation was outdated after checkout optimization logic was introduced in commit 7ab8281.

Changes

  • Updated test case: Renamed custom_checkout_keeps_github_sparsecustom_checkout_skips_github_sparse
  • Updated expectation: Changed from expecting .github sparse checkout to be present (true) to expecting it to be skipped (false) when custom checkout steps exist
  • Updated description: Reflects that sparse checkout is redundant when full checkout is already performed

Context

The new optimization in compiler_yaml_helpers.go correctly skips .github sparse checkout when custom steps contain actions/checkout, since the full repository checkout already includes .github. The test now validates this optimization works as intended.

# When this exists in custom steps:
steps:
  - name: Custom checkout
    uses: actions/checkout@v5

# The .github sparse checkout is now skipped (redundant)
Original prompt

Fix the failing GitHub Actions workflow test
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 62398072609
Job URL: https://github.com/github/gh-aw/actions/runs/21646008620/job/62398072609


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

The test was expecting .github sparse checkout to be present when custom checkout steps exist, but the new optimization logic correctly skips the sparse checkout in this case since the full checkout already includes the .github folder. Updated test expectation to match the new behavior.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions workflow test Fix TestGitHubFolderCheckoutOptimization test expectation after checkout optimization Feb 3, 2026
Copilot AI requested a review from pelikhan February 3, 2026 20:34
@pelikhan pelikhan marked this pull request as ready for review February 3, 2026 21:10
Copilot AI review requested due to automatic review settings February 3, 2026 21:10
@pelikhan pelikhan merged commit 2ee6426 into main Feb 3, 2026
6 checks passed
@pelikhan pelikhan deleted the copilot/fix-github-actions-workflow-test-again branch February 3, 2026 21:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the test expectation for TestGitHubFolderCheckoutOptimization after checkout optimization logic was introduced in commit 7ab8281. The optimization correctly skips the .github sparse checkout when custom steps contain actions/checkout, as the full repository checkout already includes .github.

Changes:

  • Updated test case name to reflect that custom checkout skips (rather than keeps) the .github sparse checkout
  • Changed expectation from true to false to match the optimization behavior
  • Updated test description to clarify the optimization logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants