Skip to content

test: add basic tests for dependency-graph & linters #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

keithamus
Copy link
Contributor

What?

This adds some basic tests for the functionality in dependency-graph, and tests the unused-export and unused-module lint rules (with a stubbed out dependency-graph)

Fixes #75

Why?

As per the issue:

These are missing tests and would be great to have when we make changes to let us know if those same changes have broken anything.

How?

The tests mostly stub out various parts dependency-graph.js so they can test the other parts in isolation. This gives us some small assurances against changes. This is a good start to tests but we can go a lot further.

@keithamus keithamus requested a review from a team November 26, 2019 15:56
@keithamus keithamus force-pushed the test-add-basic-tests-for-dependency-graph-linters branch from d63eaa8 to f9a169f Compare November 26, 2019 15:56
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! 💃

@keithamus keithamus merged commit 5eec7cb into master Nov 27, 2019
@keithamus keithamus deleted the test-add-basic-tests-for-dependency-graph-linters branch November 27, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for unused-module, unused-export & dependency-graph.js
2 participants