-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Create re-request-review reusable and use it in appropriate places #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md
Outdated
Show resolved
Hide resolved
Thanks so much for opening a PR @HonkingGoose! I'll get this triaged for review 🎉 |
@janiceilene Thanks! I will await the review from one of your teammembers then. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 Hi @HonkingGoose
Thanks for identifying and fixing this oversight in the docs. I hadn't spotted the function of that sync icon, so I learnt something new today thanks to you 🙇🏻♀️
Since this is your first pull request in this repository, I was impressed that you chose to add something that required a resuable and got it working perfectly - this isn't one of the easiest changes to make.
I've made a couple of suggestions, but this should be ready to merge once those are addressed.
content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Felicity Chapman <felicitymay@github.com>
👋 Hi @felicitymay, It's cool that I taught you something new about GitHub. 👍
Yeah that took a bit of fiddling to get it working properly. The syntax for the reusable was totally new to me, but it was well documented in the contributing docs. 😄 Those suggestions you made were really good, I can see that a competent (and native English language) content writer makes a huge difference in the quality of the text. ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 😄
Yeah that took a bit of fiddling to get it working properly. The syntax for the reusable was totally new to me, but it was well documented in the contributing docs. 😄
It's really good to hear that the docs were clear. Thanks for letting us know.
Those suggestions you made were really good, I can see that a competent (and native English language) content writer makes a huge difference in the quality of the text.
I'm always surprised to find out just how many of our contributors are non-native English speakers - some many of you have such great English 🥇
I'll get this merged. Thanks for your help improving the docs.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* added a note about the environment configuration * added a note about environment configuration * Update timescaledb/quick-start/ruby.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update timescaledb/quick-start/ruby.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update timescaledb/quick-start/ruby.md Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>
Why:
Closes #897
What's being changed:
Image of reusable:
Check off the following: