-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe how to re-request a review #897
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 @HonkingGoose I don't see anything about re requesting a PR review either! It sounds to me like you're interested in an addition that focuses on a contributor requesting an additional review after they've made changes in an already reviewed PR. Is that right? The article you linked to above ☝️ Reviewing changes in pull requests is aimed at the reviewer, so I don't think that's quite the right place for this information to live. What about adding it to either About pull request reviews? Or maybe Incorporating feedback in your pull request, since that article focuses on how to apply suggested changes and open an issue for out of scope suggestions? |
First of all, thanks for the quick response! 😄
Yes, that's right! 😄
Agree, it should go somewhere else.
Sounds good to me, I think I like this place better than " Incorporating feedback in your pull request", as that seems to me more focused on the review feedback. I can see the case for both places though. I think some keywords should be: "refresh review", "ping for a fresh review", "re-request review", I think words like that are what people would use when searching trough the documentation. I know I typed in "re-request review" and "request review" to try to find this documentation. |
The hover text says "re-request review," so I think that's what we should use here. I think it'd be beneficial to add the information to both articles. So what we can do is create a new reusable in https://github.com/github/docs/tree/main/data/reusables/pull_requests that includes:
We can add a new section called "Re-requesting reviews" to the About pull request reviews article after the "Resolving conversations" section with that reusable. We can also add a new section and reusable to Incorporating feedback in your pull request after the procedural, above the "Opening an issue for an out-of-scope suggestion" section. Anyone is welcome to open a PR implementing that plan if you want to! |
I'll go make a PR for this then. 👍 |
Co-authored-by: Lana Brindley <github@lanabrindley.com>
What article on docs.github.com is affected?
I think we should update one of the subsections belonging to this main section:
https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/reviewing-changes-in-pull-requests
What part(s) of the article would you like to see updated?
Why should the docs be changed?
I can't find anything in the GitHub docs about re-requesting a review??? I would expect it to be in one of the articles in the Reviewing changes in pull requests section, but I can't find it there at all.
What use cases does it support?
This should be documented somewhere, so that repository maintainers can link to this section to explain how "re-requesting an review" works.
This also exposes this functionality to anyone who reads the GitHub docs, that way they can "stumble into" this functionality.
Expected outcome
There is a section in the GitHub docs that explains that you can click on the refresh icon next to a review, to ping the reviewer for a fresh review.
Additional information
See the image below for an example of the refresh icon that I'm talking about:
The text was updated successfully, but these errors were encountered: