fix: Use pull_request_target for SECRET access #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nschonni! I'll get this triaged for review 🌟 |
|
Got eyes on this and the others @nschonni! I'll plan to review and merge some of these PRs early-mid next week! |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
4 tasks
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* Adding missng page for compressing continuous aggregates * Apply suggestions from code review Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update timescaledb/how-to-guides/continuous-aggregates/compression-on-continuous-aggregates.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The script uses a SECRET value, so it needs to be run in the
pull_request_targetcontext to be able to access the value.There was also an empty
namefor the step that was just removed instead of duplicating the title of the ActionWhat's being changed:
Check off the following: