Skip to content

chore: flatten and document pinned actions #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 25, 2020

Why:

There are a few different versions of the sha versions of the action/* tasks used across the various jobs. This standardizes them on the latest versions and document what the sha commit actually represents.

What's being changed:

Moves all the existing pinned hashed versions of the actions/* libraries to their latest versions that are already in use here. Adding notes in the file that controls the allowed version to indicated the upstream friendly version number in order to more easily find what version the hashes represent.

Check off the following:

@nschonni nschonni requested a review from a team as a code owner October 25, 2020 21:45
@janiceilene
Copy link
Contributor

👋 @nschonni Thanks for opening a PR! Is this still in progress? When you're ready for review, can you fill out the pull request template and let me know? Then I'll get it triaged for you!

@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 28, 2020
@nschonni
Copy link
Contributor Author

@janiceilene I've checked off the checkboxes now

@janiceilene
Copy link
Contributor

@nschonni Could you fill out the Why? and What's being changed: sections to help ensure that this is triaged to the right team(s) for review, thanks!

@nschonni
Copy link
Contributor Author

@janiceilene done

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Oct 28, 2020
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@chiedo
Copy link
Contributor

chiedo commented Nov 3, 2020

This is fantastic @nschonni!

@chiedo
Copy link
Contributor

chiedo commented Nov 3, 2020

@nschonni seeing a test failure. It looks like actions/github-script@44b873bc975058192f5279ebe7579496381f575d is referenced somewhere in the codebase but it isn't in the allowed actions list. So you may need to update a reference somewhere to the latest version of github script and confirm it still works / there aren't any breaking changes.

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2020

Think #864 created a conflict after merging the branch. I'll rebase it

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2020

@chiedo CI is green again 😄

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2020

@chiedo fixed the failure for the new job in bce0499

@chiedo chiedo merged commit 2e47c25 into github:main Nov 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the actions-hash branch November 3, 2020 20:27
@Realest1Re Realest1Re mentioned this pull request Nov 20, 2021
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Release notes 2.5.2

* Update timescaledb/overview/release-notes/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants