update docs to specify Metadata access #3861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georgicodes Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
janiceilene
added
the
waiting for review
mchammer01
reviewed
Mar 3, 2021
content/developers/apps/setting-up-your-development-environment-to-create-a-github-app.md
Outdated
Show resolved
Hide resolved
…t-to-create-a-github-app.md
mchammer01
reviewed
Mar 3, 2021
sexysunar
approved these changes
Mar 7, 2021
sexysunar
approved these changes
Mar 7, 2021
3 tasks
mchammer01
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
@georgicodes - thanks again for raising this PR and answering my (sometimes silly) questions ✨
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This was referenced Oct 14, 2021
This was referenced Oct 22, 2021
This was referenced Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the "Creating a github app" docs. It fixes an outdated instruction when creating a new app to "Leave this page with its default values". When these instructions were written, apps were created with the
metadatapermission by default, however this is no longer the case (slack conversation).Creating an app with no permissions is a little confusing for firstime app users, when you go to install the app you are then faced with this screen:
I think instead for the purposes of this tutorial, let's have them select metadata perms, so that the rest of the screenshots in that tutorial still make sense, eg:
What's being changed:
rendered
Check off the following: