Skip to content

Update updating-credentials-from-the-macos-keychain.md #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Update updating-credentials-from-the-macos-keychain.md #3610

merged 5 commits into from
Mar 4, 2021

Conversation

victorlin
Copy link
Contributor

@victorlin victorlin commented Feb 11, 2021

Cloning public repositories does not prompt for credentials.

Why:

Current documentation is not accurate.

What's being changed:

Clarify that cloning only private repositories will prompt authentication.

Check off the following:

Cloning public repositories does not prompt for credentials.
@welcome
Copy link

welcome bot commented Feb 11, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@victorlin victorlin marked this pull request as ready for review February 11, 2021 15:44
@janiceilene
Copy link
Contributor

@victorlin Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core waiting for review Issue/PR is waiting for a writer's review labels Feb 12, 2021
Copy link
Contributor

@myarb myarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making this change! I'm updating this branch from main and we'll get it merged 🔜

@myarb myarb added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 3, 2021
@shati-patel shati-patel enabled auto-merge (squash) March 4, 2021 14:36
@shati-patel shati-patel merged commit 8d9d3e1 into github:main Mar 4, 2021
@victorlin victorlin deleted the patch-1 branch March 6, 2021 05:07
@Good2G

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants