Skip to content

docs(actions): fix two internal links #25087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2023
Merged

docs(actions): fix two internal links #25087

merged 3 commits into from
Apr 21, 2023

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Apr 18, 2023

Why:

Internal links [`paths`](#onpushpull_requestpull_request_targetpathspaths-ignore) written in two reusables lead to invalid links in doc page "Trigger a workflow".

Closes: #25086

What's being changed (if available, include any code snippets, screenshots, or gifs):

A path to file where the anchor #onpushpull_requestpull_request_targetpathspaths-ignore lives is prepended to the link. The linked text is also extended to include paths-ignore.

The two modified reusables are both used twice, one in page "Trigger a workflow" and one in page "Workflow syntax". Before, the links only work in "Workflow syntax" page. This PR makes the links work in both pages.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 18, 2023
@cmwilson21
Copy link
Contributor

@muzimuzhi Thank you for opening a PR and linking it to your issue! ✨

We appreciate all the additional information and detailed context 💖

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 19, 2023
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Apr 20, 2023
@cmwilson21 cmwilson21 enabled auto-merge April 21, 2023 18:52
@cmwilson21 cmwilson21 added this pull request to the merge queue Apr 21, 2023
Merged via the queue into github:main with commit f3438f0 Apr 21, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@muzimuzhi muzimuzhi deleted the fix-internal-links branch April 21, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(actions): invalid link caused by an internal link in reusable
3 participants