docs(actions): invalid link caused by an internal link in reusable

[muzimuzhi]

Code of Conduct

• I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/triggering-a-workflow

What part(s) of the article would you like to see updated?

In https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-filters-to-target-specific-branches-for-pull-request-events, it reads

If you define both branches/branches-ignore and paths, the workflow will only run when both filters are satisfied.

In another section of the same page https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-filters-to-target-specific-branches-or-tags-for-push-events, it reads

If you define both branches/branches-ignore and paths, the workflow will only run when both filters are satisfied.

Here the two "paths"

• are both linked to the same, non-existent target on the same page
  https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#onpushpull_requestpull_request_targetpathspaths-ignore
• while the expected target is in another page
  https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

Additional information

This is caused by the use of an internal link in reusable, see line 5 below

[`paths`](#onpushpull_requestpull_request_targetpathspaths-ignore)

docs/data/reusables/actions/workflows/section-triggering-a-workflow-branches.md

Lines 5 to 7 in 1b90194

	If you define both `branches`/`branches-ignore` and [`paths`](#onpushpull_requestpull_request_targetpathspaths-ignore), the workflow will only run when both filters are satisfied.
	The `branches` and `branches-ignore` keywords accept glob patterns that use characters like `*`, `**`, `+`, `?`, `!` and others to match more than one branch name. If a name contains any of these characters and you want a literal match, you need to escape each of these special characters with `\`. For more information about glob patterns, see the "[AUTOTITLE](/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet)."

When one reusable is used by different pages, in most cases internal links like [text](#target) will lead to invalid url in at least one of those rendered pages. The correct way is to tell the full path of the target page, like another link in line 7 in snippet above,

[AUTOTITLE](/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet)

I'll provide a PR.

[cmwilson21]

@muzimuzhi Thank you for opening an issue and linking it to your PR! ✨

And thanks for providing all this extra context! 💖

[peterbe]

I did a search for the pattern of in-page anchor links with the data/reusables/. Wow, there's a lot!

I wonder if we have a lot of these busted in-page anchor links due to this very situation that @muzimuzhi so rightfully spotted.

We currently don't have a link checker for anchor links. It's something we've discussed and will continue to discuss. This issue here certainly helps. Thanks @muzimuzhi !

/CC @sarahs

[muzimuzhi]

@peterbe I've reported the general case in #25088.

[Raygrantham51]

Ray Grantham Jr has invited you to join a Blend on Spotify. Join on the Spotify mobile app. https://open.spotify.com/blend/taste-match/fe91e7f25a296916?si=h6iRjZiVSJajXNiA052pNg&fallback=getapp

…

On Thu, Apr 20, 2023, 9:13 PM Yukai Chou ***@***.***> wrote: @peterbe <https://github.com/peterbe> I've reported the general case in #25088 <#25088>. — Reply to this email directly, view it on GitHub <#25086 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6AUNLZIJFVWBR6F356AYHLXCHNKNANCNFSM6AAAAAAXDFGE2E> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>