-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Note that PKCE is not supported #24965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
@github/ecosystem-apps-reviewers Can you review this PR from a technical perspective? |
This comment was marked as spam.
This comment was marked as spam.
Tagging in @hpsin to review for @github/ecosystem-apps-reviewers. 🙇 |
content/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including this @hickford ! Looking forward to replacing it with details of how to use these once we are able to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>
Most other OAuth servers support PKCE, so it's worthwhile to note this limitation of GitHub. at https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps
Also because of security implementations https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics#section-4.7.1
Check off the following: