Skip to content

Note limitation about OAuth client types #24964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Apr 10, 2023

OAuth developers expect to be able to specify client type during OAuth registration, so it's worthwhile to note this limitation.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 10, 2023
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/oauth-apps/building-oauth-apps/creating-an-oauth-app.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@steveward steveward added developers Content related to developers needs SME This proposal needs review from a subject matter expert content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Apr 12, 2023
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@steveward steveward added the waiting for review Issue/PR is waiting for a writer's review label Apr 12, 2023
@steveward
Copy link
Member

Thanks for the PR @hickford, I'll get this triaged for review as well.

@skedwards88
Copy link
Contributor

@github/ecosystem-apps-reviewers Could you review this from a technical standpoint?

@hickford hickford mentioned this pull request Apr 24, 2023
2 tasks
@hpsin
Copy link
Member

hpsin commented Apr 24, 2023

I'd like to not include this. We are updating docs to add nuance here, but I don't want to say that we assume all are confidential. That's not quite true and we're adding additional logic now that distances us even further.

@hickford hickford closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants