Skip to content

Fix casing of GeoJSON/TopoJSON #19029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Fix casing of GeoJSON/TopoJSON #19029

merged 5 commits into from
Jul 21, 2022

Conversation

letmaik
Copy link
Contributor

@letmaik letmaik commented Jul 15, 2022

Why:

File formats were spelled incorrectly.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Casing.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 15, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae
get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams.md fpt
ghec
fpt
ghec

@cmwilson21
Copy link
Contributor

@letmaik Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 15, 2022
@felicitymay
Copy link
Contributor

felicitymay commented Jul 21, 2022

Hi @letmaik - thanks for opening this pull request and its partner #19030.

I can see from https://geojson.org/ that your change makes sense, but it looks as if we use the current casing throughout the docs. Before I approve these two pull requests, I'll check in on whether there is a reason for using a different casing.

@felicitymay
Copy link
Contributor

👋🏻
I've had confirmation that this change is fine 🙂

I'd like to ensure that we update this consistently across all files, doing a local search I see that we have this capitalization in the following files:

  • content/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams.md:

    • ✅ Fixed in this pull request ✨
  • content/repositories/working-with-files/using-files/working-with-non-code-files.md:

  • content/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks.md:

    71  
    72: You can also use code blocks to create diagrams in Markdown. GitHub supports Mermaid, geoJSON, topoJSON, and ASCII STL syntax. For more information, see "[Creating diagrams](/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams)."
    73  
    
  • data/glossaries/internal.yml:

    211: - term: geoJSON
    212    description: A format for encoding a variety of geographic data structures.
    
    621: - term: topoJSON
    622  description: An extension of GeoJSON that encodes topology.
    

I wondered if you'd be interested in opening pull requests to fix the remaining two files? Then we can merge them all together.

felicitymay
felicitymay previously approved these changes Jul 21, 2022
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 🙂

@letmaik
Copy link
Contributor Author

letmaik commented Jul 21, 2022

I added the remaining changes to this PR.

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those updates so quickly 💖
Very much appreciated.

I'll get these two PRs merged shortly and you should see the changes on the live site in a couple of hours or so.

@felicitymay felicitymay merged commit a76842c into github:main Jul 21, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants