-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Fix casing of GeoJSON/TopoJSON #19029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@letmaik Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
Hi @letmaik - thanks for opening this pull request and its partner #19030. I can see from https://geojson.org/ that your change makes sense, but it looks as if we use the current casing throughout the docs. Before I approve these two pull requests, I'll check in on whether there is a reason for using a different casing. |
👋🏻 I'd like to ensure that we update this consistently across all files, doing a local search I see that we have this capitalization in the following files:
I wondered if you'd be interested in opening pull requests to fix the remaining two files? Then we can merge them all together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update 🙂
I added the remaining changes to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those updates so quickly 💖
Very much appreciated.
I'll get these two PRs merged shortly and you should see the changes on the live site in a couple of hours or so.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
File formats were spelled incorrectly.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Casing.
Check off the following:
Writer impact (This section is for GitHub staff members only):