Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of GeoJSON/TopoJSON #19030

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Fix casing of GeoJSON/TopoJSON #19030

merged 3 commits into from
Jul 21, 2022

Conversation

letmaik
Copy link
Contributor

@letmaik letmaik commented Jul 15, 2022

Why:

Fixes casing of GeoJSON/TopoJSON file formats.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Casing.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/working-with-files/using-files/working-with-non-code-files.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae

@cmwilson21
Copy link
Contributor

@letmaik Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Jul 15, 2022
@felicitymay felicitymay mentioned this pull request Jul 21, 2022
5 tasks
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on #19029, this change looks good.

I'll wait to hear back from you on #19029 (comment) before deciding when best to merge your two pull requests.

@felicitymay felicitymay enabled auto-merge (squash) July 21, 2022 16:51
@felicitymay felicitymay added the ready to merge This pull request is ready to merge label Jul 21, 2022
@felicitymay felicitymay merged commit 2d81831 into github:main Jul 21, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants