Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax for GitHub's form schema is incorrect with relation to IDs #9004

Closed
1 task done
ciaransweet opened this issue Aug 9, 2021 · 9 comments · Fixed by #9045
Closed
1 task done

Syntax for GitHub's form schema is incorrect with relation to IDs #9004

ciaransweet opened this issue Aug 9, 2021 · 9 comments · Fixed by #9045
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@ciaransweet
Copy link

Code of Conduct

  • I have read and agree to the GitHub Docs project's Code of Conduct.

What article on docs.github.com is affected?

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema

What part(s) of the article would you like to see updated?

When trialling out the .yaml issue form templates, I came across the following error:
image

As you can see, it states that: body[0]: id is not a permitted attribute.

Yet here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#attributes-4, id is explicitly an allowed attribute. If I move the ID to the type/attributes level of the checkboxes entry I get:

image

The same also happens on dropdown types:

image

I would assume the same is for all types that have id listed as an attribute.

Additional information

I'd be happy to raise a PR to change the docs, but I'm not sure if the docs are right and the implementation is wrong, or the implementation is right and the docs are wrong 😄

@welcome
Copy link

welcome bot commented Aug 9, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@ramyaparimi
Copy link
Contributor

@ciaranevans
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@docubot
Copy link
Contributor

docubot commented Aug 10, 2021

Thank you for opening this issue! Changes to the REST API schema can be requested in github/rest-api-description. I will transfer your issue over to that open source repo.

@docubot docubot transferred this issue from github/docs Aug 10, 2021
@ciaransweet
Copy link
Author

@ramyaparimi I'm not sure this was moved correctly, the issue is indeed in the GitHub docs directory? Or is this moved because the implementation on the API is wrong against the docs?

@ramyaparimi
Copy link
Contributor

@ciaranevans This is something that's fixed internally so your issue has been transferred to an internal repo 👍

@ciaransweet
Copy link
Author

@ramyaparimi got you, thanks for clarifying!

@skedwards88
Copy link
Contributor

👋 Apologies for mis-transferring this! This can be fixed in the public docs repo, so I am going to transfer it back.

Thank you for the detailed issue about how to reproduce the error!

I'd be happy to raise a PR to change the docs, but I'm not sure if the docs are right and the implementation is wrong, or the implementation is right and the docs are wrong 😄

The docs should be fixed here 😄 You or anyone else is welcome to open a PR to fix this issue.

@skedwards88 skedwards88 transferred this issue from github/rest-api-description Aug 12, 2021
@welcome
Copy link

welcome bot commented Aug 12, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@skedwards88 skedwards88 added the help wanted Anyone is welcome to open a pull request to fix this issue label Aug 12, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 12, 2021
@skedwards88 skedwards88 removed the triage Do not begin working on this issue until triaged by the team label Aug 12, 2021
@thispsj
Copy link
Contributor

thispsj commented Aug 14, 2021

@skedwards88 I got this and will send in a PR soon.

Hey, I sent a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants