-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax for GitHub's form schema is incorrect with relation to IDs #9004
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@ciaranevans |
Thank you for opening this issue! Changes to the REST API schema can be requested in github/rest-api-description. I will transfer your issue over to that open source repo. |
@ramyaparimi I'm not sure this was moved correctly, the issue is indeed in the GitHub docs directory? Or is this moved because the implementation on the API is wrong against the docs? |
@ciaranevans This is something that's fixed internally so your issue has been transferred to an internal repo 👍 |
@ramyaparimi got you, thanks for clarifying! |
👋 Apologies for mis-transferring this! This can be fixed in the public docs repo, so I am going to transfer it back. Thank you for the detailed issue about how to reproduce the error!
The docs should be fixed here 😄 You or anyone else is welcome to open a PR to fix this issue. |
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Hey, I sent a PR. |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
What part(s) of the article would you like to see updated?
When trialling out the
.yaml
issue form templates, I came across the following error:As you can see, it states that:
body[0]: id is not a permitted attribute.
Yet here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#attributes-4,
id
is explicitly an allowed attribute. If I move the ID to thetype/attributes
level of thecheckboxes
entry I get:The same also happens on
dropdown
types:I would assume the same is for all types that have
id
listed as an attribute.Additional information
I'd be happy to raise a PR to change the docs, but I'm not sure if the docs are right and the implementation is wrong, or the implementation is right and the docs are wrong 😄
The text was updated successfully, but these errors were encountered: