Fixes the description about id key in Issue Forms.
#9045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9004 The `id` key is the top level key and has been misplaced in the `attributes` key. Luckily the examples do not have any such error,
ghost
temporarily deployed
to
docs-9045--fixforms
github-actions
bot
added
the
triage
ramyaparimi
added
content
|
@thispsj Thanks so much for opening a PR! I got this triaged for review ⚡ |
guntrip
reviewed
Aug 24, 2021
...ing-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema.md
Outdated
Show resolved
Hide resolved
|
@thispsj 👋 Would you mind either enabling the checkbox to allow maintainer edits (so I can commit the suggested change above) or committing it yourself? Then I can get this merged in. Thank you! |
thispsj
dismissed stale reviews from guntrip, ghost
, ghost
, quasialaw, and ciaransweet
via
ece3a8f
|
@stevecat done. |
guntrip
reviewed
Aug 24, 2021
...ing-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>
|
@stevecat you can enable automerge now I guess |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Closes #9004
What's being changed:
The
idkey is used in issue forms with every type (excluding markdown). But the docs mention that theattributeskey should contain it which is wrong. Theidkey is a top-level key in each type.Check off the following: