C#: Fix compilation of ValueNumberingInternal #2870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
approved these changes
Feb 19, 2020
|
I might be wrong, but I think Also: There's an open PR (#2839) that adds |
|
@MathiasVP Ok, let's hold off merging this PR then and wait for #2839. |
|
Is this PR still needed now that #2839 is merged? |
|
I tested the build command, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the compilation of C# qldocs, for example
build target/packs/pack-csharp-qldoc.zipon the internal repository.I'm not quite sure what
TLoadTotalOverlapValueNumbermeans for C# so I left itnone(). Since C# doesn't haveunion, this is probably correct.