Skip to content

C++/C#: Fix sync config file for value numbering sharing #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2020
Merged

C++/C#: Fix sync config file for value numbering sharing #2839

merged 4 commits into from
Feb 19, 2020

Conversation

MathiasVP
Copy link
Contributor

The identical-files.json file was not specifying that ValueNumberingInternal.qll files should be shared between C# and C++.

@MathiasVP MathiasVP requested review from a team as code owners February 13, 2020 21:36
dbartol
dbartol previously approved these changes Feb 13, 2020
View reviewed changes
Copy link

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdmarsh2
Copy link
Contributor

Note that this will have a sync conflict with #2835

@MathiasVP MathiasVP force-pushed the sync-ir-valuenumbering-internals branch from e6ab99e to 98db6d8 Compare February 14, 2020 07:22
jbj
jbj reviewed Feb 14, 2020
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's postpone merging this until we've merged the release-critical ValueNumbering fixes that are in conflict with this PR.

@MathiasVP MathiasVP mentioned this pull request Feb 19, 2020
Closed
calumgrant
calumgrant approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell. Syncing these files certainly makes sense.

@jbj jbj merged commit 1d2d872 into github:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj left review comments

@calumgrant calumgrant calumgrant approved these changes

@dbartol dbartol dbartol left review comments

Assignees
No one assigned
Labels
C# C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MathiasVP @rdmarsh2 @jbj @calumgrant @dbartol