Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Add support for provenance pretty-printing as a qltest postprocess step #17014

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jul 18, 2024

Based on #17011, so don't merge until that is merged.

@owen-mc owen-mc marked this pull request as ready for review July 26, 2024 08:38
@owen-mc owen-mc requested review from a team as code owners July 26, 2024 08:39
@owen-mc owen-mc force-pushed the go/provenance-postprocess-qltest branch from 8fe6166 to d432033 Compare July 26, 2024 08:41
@aschackmull
Copy link
Contributor

aschackmull commented Jul 26, 2024

It still shows the changes from #17011. Did you mean to rebase?

@owen-mc owen-mc force-pushed the go/provenance-postprocess-qltest branch from d432033 to f307f27 Compare July 28, 2024 20:31
@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jul 28, 2024
@owen-mc owen-mc removed the request for review from a team July 29, 2024 07:01
@owen-mc
Copy link
Contributor Author

owen-mc commented Jul 29, 2024

Yes, I ran out of time. I've done it now (and I was pleasantly surprised to see I could remove codeql-java as a reviewer).

@owen-mc owen-mc merged commit 0a7772d into github:main Jul 29, 2024
10 checks passed
@owen-mc owen-mc deleted the go/provenance-postprocess-qltest branch July 29, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants