-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared: Add support for provenance pretty-printing as a qltest postprocess step. #17011
Shared: Add support for provenance pretty-printing as a qltest postprocess step. #17011
Conversation
|
||
external predicate queryRelations(string relation); | ||
|
||
query predicate resultRelations(string relation) { queryRelations(relation) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we need this line. I assume it's linked to the post-processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. It basically ensures that we keep any empty tables instead of discarding them (so this mostly applies to the subpaths
predicate).
884eff6
to
94078e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will approve when the next release is out.
An integration test kept on failing, so I merged in |
@aschackmull I believe this is ready to be merged now 🎉 . |
Follow-up for #16210. With post-processing of qltest output we can now do this in a much nicer way.