C++: Use unique in hasIRRepresentationOfIndirectInstruction
#14376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar to how it's done in 'hasIRRepresentationOfIndirectOperand'.
MathiasVP
changed the title
hasIRRepresentationOfIndirectInstructionunique in hasIRRepresentationOfIndirectInstruction
MathiasVP
force-pushed
the
unique-in-hasIRRepresentationOfIndirectInstruction
branch
from
921817c to
e38f659
Compare
jketema
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicate
hasIRRepresentationOfIndirectInstructionintroduced in #14008 didn't require the address had a single use. This gave some new FPs when upgrading the frontend. This PR fixes these regressions by requiring uniqueness (just like its sister predicatehasIRRepresentationOfIndirectOperanddoes).cc @jketema