Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for CodeQL 2.12.5 and earlier #2232

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Remove support for CodeQL 2.12.5 and earlier #2232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f1e244
Bump minimum CodeQL Bundle version to 2.12.6
henrymercer Apr 9, 2024
2f0d0ea
Update PR checks
henrymercer Apr 9, 2024
1a60a91
Remove support for CodeQL v2.12.5 and earlier
henrymercer Apr 9, 2024
88fafeb
Update diagnostics export PR check to use 2.12.6
henrymercer Apr 9, 2024
5e9199f
Update language autodetect Swift check
henrymercer Apr 9, 2024
ee097ce
Add changelog note
henrymercer Apr 9, 2024
987236c
Merge branch 'main' into henrymercer/remove-support-codeql-2.12.5
henrymercer Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update diagnostics export PR check to use 2.12.6
  • Loading branch information
@henrymercer
henrymercer committed Apr 9, 2024
commit 88fafebdd3d1b6d3bf2456760ec45076fb8bf3cc
8 changes: 4 additions & 4 deletions .github/workflows/__diagnostics-export.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pr-checks/checks/diagnostics-export.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: "Diagnostic export"
description: "Tests that manually added diagnostics are correctly exported to SARIF."
# Test on 2.12.5 (which requires a workaround in the Action), the latest release, and the latest
# Test on 2.12.6 (which requires a workaround in the Action), the latest release, and the latest
# nightly.
versions: ["stable-20230317", "latest", "nightly-latest"]
versions: ["stable-20230403", "latest", "nightly-latest"]
env:
CODEQL_ACTION_EXPORT_DIAGNOSTICS: true
steps:
Expand All @@ -17,7 +17,7 @@ steps:
CODEQL_PATH: ${{ steps.init.outputs.codeql-path }}
run: |
for i in {1..2}; do
# Use the same location twice to test the workaround for the bug in CodeQL CLI 2.12.5 that
# Use the same location twice to test the workaround for the bug in CodeQL CLI 2.12.6 that
# produces an invalid diagnostic with multiple identical location objects.
"$CODEQL_PATH" database add-diagnostic \
"$RUNNER_TEMP/codeql_databases/javascript" \
Expand Down
Loading