-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for CodeQL 2.12.5 and earlier #2232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 just one comment!!
'name': 'Set environment variable for Swift enablement', | ||
'if': "runner.os != 'Windows' && matrix.version == '20221211'", | ||
'shell': 'bash', | ||
'run': 'echo "CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true" >> $GITHUB_ENV' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this conditional too:
env.CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT == 'true' || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Follow up to #2220 where we announced that support for CodeQL v2.12.5 and earlier would be removed after these versions were deprecated alongside GHES 3.8.
We'll need to update the set of required PR checks before merging this.
Merge / deployment checklist