Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Feb 5, 2019

What this PR does

Entering a repository or /blob/ URL into the filter box should allow the repository to be cloned or opened.

  • Light up Clone or Open button when a valid URL is entered into filter box
  • Deactivate Clone and Open buttons when URL is no longer valid

How to test

Allow /blob/ URLs

  1. Open Open from GitHub dialog
  2. Paste a blob URL into filter (e.g https://github.com/github/VisualStudio/blob/master/README.md)
  3. Clone or Open button should activate

Deactivate buttons when URL is invalid

  1. Open Open from GitHub dialog
  2. Paste a repository URL into filter (e.g https://github.com/foo/bar)
  3. Clone or Open button should activate
  4. Delete the end of URL until it's no longer valid (e.g https://github.com/foo/)
  5. Clone or Open button should become inactive

Fixes #2214

Also check that changing from a valid repository/blob URL to an invalid
URL causes the Clone/Open buttons to become inactive.
@jcansdale jcansdale merged commit 7568520 into master Feb 5, 2019
@jcansdale jcansdale deleted the fixes/2214-open-from-github-url-filter branch February 5, 2019 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants