Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Branch Search Hidden Input #4984

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: Branch Search Hidden Input #4984

merged 1 commit into from
Sep 27, 2024

Conversation

navtoj
Copy link
Contributor

@navtoj navtoj commented Sep 27, 2024

☕️ Reasoning

The search input was hidden using the opacity property which allowed users to type into it.

🧢 Changes

The search input is now hidden using the visibility property to prevent any interaction (typing, cursor change on hover, etc).

🎫 Affected issues

Fixes: #4983

Copy link

vercel bot commented Sep 27, 2024

@navtoj is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for reporting the issue and for researching and producing a fix, it's much appreciated!

I also successfully validated the fix - merging.

@Byron
Copy link
Collaborator

Byron commented Sep 27, 2024

@krlvi It looks like E2E Tests / Run WebdriverIO Tests (pull_request) could be added to the 'Required Checks' section of the protected branch configuration to let me 'enable auto-merge' while it is running. Right now it would allow me to merge while E2E is running.

@Byron Byron merged commit adf43a5 into gitbutlerapp:master Sep 27, 2024
12 of 13 checks passed
@navtoj navtoj deleted the Branch-Search-Hidden-Input branch September 27, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch Search Hidden Input
2 participants