Branch Search Hidden Input

[navtoj]

Version

0.12.26 (20240924.135933)

Operating System

Mac OS X

Distribution Method

dmg (Apple Silicon)

Describe the issue

It is possible to search through the branches even when the search input is not visible.

Branch.Search.Hidden.Input.mov

How to reproduce

Click within the area marked in the screenshot below and start typing.

Expected behavior

The user should not be able to access the search input when it's in a hidden state.

Relevant source code

gitbutler/apps/desktop/src/lib/navigation/Branches.svelte

Line 21 in 01584fc

let searching = $state(false);

gitbutler/apps/desktop/src/lib/navigation/Branches.svelte

Lines 112 to 125 in 01584fc

	<div class="search-container" class:show-search={searching}>
	<button tabindex={searching ? -1 : 0} class="search-button" onclick={toggleSearch}>
	<Icon name={searching ? 'cross' : 'search'} />
	</button>
	<input
	bind:this={searchEl}
	bind:value={$searchTerm}
	class="search-input text-13"
	type="text"
	placeholder="Search branches"
	onkeydown={handleSearchKeyDown}
	/>
	</div>

gitbutler/apps/desktop/src/lib/navigation/Branches.svelte

Lines 284 to 294 in 01584fc

	.show-search {
	width: 100%;
	& .search-button::after {
	transform: scale(0.7);
	}
	& .search-input {
	opacity: 1;
	}
	}