Usability bug fix #232
Merged
Usability bug fix #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the opacity slider was moved to the far right faster than the animation showing the image, the user would never see the old file because opacity got adjusted right away. Now we first move the overlay slider to the right, so that something is visible, and then quickly animate opacity to the current value.
|
thx |
tomaswolf
added a commit
to tomaswolf/gerrit-gitblit-plugin
that referenced
this pull request
Nov 21, 2014
This is a GitBlit 1.7.0 preview: essentially * gitblit-org/gitblit#229 * gitblit-org/gitblit#230 * gitblit-org/gitblit#231 * gitblit-org/gitblit#232 Replace the CSS-based slider by a JavaScript-based one, plus blink comparator, plus pixel difference on browsers that support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the opacity slider was moved to the far right faster than the
animation showing the image, the user would never see the old file
because opacity got adjusted right away.
Now we first move the overlay slider to the right, so that something
is visible, and then quickly animate opacity to the current value.
Fixes the issue mentioned in #231.