IE < 10 does not support gradients. #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the new imgdiff UI heavily used gradients, this leaves IE9 and IE8 users with a complete disfunctional UI. Replaced all gradients by simpler means: * Vertical handle: instead of 2px wide gradient, use a 1px background and a white border-right * Opacity slider: No gradient but a simple border and background-color * All radial-gradients replaced by small pre-computed PNGs * Checkerboard background done with a small repeated PNG With these changes, the imgdiff UI is fully functional even in IE 8. Visual changes in other browsers are barely discernible.
|
BTW: looking at https://dev.gitblit.com/commitdiff/mirrors!ninja.git/948eeb44257529c03df2ef46a226565beae9fb67 I wonder why .svg is not an image extension. Support for that seems to be pretty widespread... |
gitblit
added a commit
that referenced
this pull request
Nov 18, 2014
IE < 10 does not support gradients.
tomaswolf
added a commit
to tomaswolf/gerrit-gitblit-plugin
that referenced
this pull request
Nov 21, 2014
This is a GitBlit 1.7.0 preview: essentially * gitblit-org/gitblit#229 * gitblit-org/gitblit#230 * gitblit-org/gitblit#231 * gitblit-org/gitblit#232 Replace the CSS-based slider by a JavaScript-based one, plus blink comparator, plus pixel difference on browsers that support it.
gitblit
added a commit
that referenced
this pull request
Jan 13, 2015
|
some thing i test in my win10 it ti's work so happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this is embarrassing. I did after all find an old PC on which to test this with IE 8 and got a crappy UI missing most but not all parts. Quickly discovered that IE < 10 does not support gradients, which I had used extensively. Had never occurred to me that even IE9 might not have this.
Since IE9 and IE8 are still in use (a total of 5% according to caniuse, some other sites report much higher values) I guess it's worth catering to users who have to use such old browsers (especially corporate users who have an unfortunate tendency to lag behind).
See the commit comment for the changes. Basically, I've replaced all gradients by simpler CSS or PNGs. Visually the UI is pretty much the same, and it now works (and looks good) even on poor old IE8.