Bump deployment target to 10.10 #534
Conversation
zwaldowski
force-pushed
the
bump-deployment
branch
from
9c33d14 to
eb7b025
Compare
| @@ -485,7 +486,7 @@ | |||
| E21DCAEC1B253847006424E8 /* Debug */ = { | |||
| isa = XCBuildConfiguration; | |||
| buildSettings = { | |||
| GCC_DYNAMIC_NO_PIC = YES; | |||
| CODE_SIGN_IDENTITY = "Mac Developer"; | |||
There was a problem hiding this comment.
Does this try and default to your current profile?
There was a problem hiding this comment.
Yes. The main app is set the same way, this is for the command-line tool.
There was a problem hiding this comment.
The annoyance here though is that the Tool target will complain when I build for the Application scheme. Is this a necessary change, seems more annoying that useful, unless I'm missing something.
There was a problem hiding this comment.
The annoyance here though is that the Tool target will complain when I build for the Application scheme.
What warning are you seeing, I don't see one?
There was a problem hiding this comment.
FWIW signing Command-Line Tools is now required.
There was a problem hiding this comment.
EDIT: Ah, the DEVELOPMENT_TEAM needed to be moved to the project level. I run my branches with an additional commit changing the Development Team to mine — since I'm not a member of the team and I can't build at all otherwise — and then delete it before pushing, so I did not catch it. This will be completed in one last push. :)
|
Will update to address comments shortly. Thanks! |
zwaldowski
force-pushed
the
bump-deployment
branch
2 times, most recently
from
63bb877 to
c589b18
Compare
|
Updated. Making all the projects share the same config made for a nice cleanup, so this is a win all around. |
| IPHONEOS_DEPLOYMENT_TARGET = 8.0 | ||
|
|
||
| DEBUG_INFORMATION_FORMAT = dwarf-with-dsym | ||
| COMBINE_HIDPI_IMAGES = YES | ||
| TARGETED_DEVICE_FAMILY = 1,2,3,4 | ||
| COPY_PHASE_STRIP = NO |
There was a problem hiding this comment.
Why do we want this moved to the base config? Don't we want to strip symbols in the release configurations?
There was a problem hiding this comment.
You can't run stripping on a code-signed binary (like the third-party frameworks we embed) because it breaks its code-signing, so that emits a warning without a change. COPY_PHASE_STRIP = NO is now the default on new Xcode projects in all configurations.
|
I think that about wraps up my questions. Sorry, there's just a lot of change here. Going forward if we can try and minimize changes where possible, it would be helpful in speeding up reviews. Obviously Dark Mode is an exception to this type of thing being an all or nothing proposition. I really appreciate the effort though, really glad to see GitUp moving forward! |
zwaldowski
force-pushed
the
bump-deployment
branch
from
c589b18 to
4c19500
Compare
zwaldowski
force-pushed
the
bump-deployment
branch
from
4c19500 to
aa71298
Compare
|
Updated. |
|
Thanks! I’ll take a look tonight and will likely merge in. I’m on vacation so that’s why I’m somewhat sporadic in my responses, doing code reviews at night. |
|
Oh my goodness, please enjoy your vacation first and foremost! You'd better be doing review with a drink in hand! 🍹 |
zwaldowski
force-pushed
the
bump-deployment
branch
from
aa71298 to
ea845aa
Compare
zwaldowski
force-pushed
the
bump-deployment
branch
from
ea845aa to
d3a6dfb
Compare
* Perform Xcode 10.2 modernization * Update deployment target to 10.9 * Fixes libgit2 reference in GitUpKit for iOS * Make all targets use shared config * Adopt base localization * Update the tools used to build on CI * Adopt guarded availability checking * NSViewController is part of the responder chain after 10.10 * NSViewController has native appearance callbacks after 10.10 * Fix trivial warnings * Update deployment target to 10.10
As discussed in #463 and #532.
Not much to comment on here, should be no functional change except (extremely) greasing the wheels for #532. It takes the shortest path to get to a warning-free build on the newer deployment target.