Support for macOS Mojave's dark mode

[saagarjha]

I thought I'd create an issue to track dark mode support on macOS Mojave. I have a branch set up that has some preliminary support (it also has what I think is a slightly nicer fix for #459, and some other improvements). Here's what it looks like currently:

Is there anyone else working on this?

[sdgandhi]

Love it. Small UI feedback: full white is harsh on dark backgrounds, try 80-90% opacity white. And the other key colors (red, green, etc.) probably need to be dulled a little too.

[saagarjha]

I'm sorry, what white are you talking about? The only white I see is the app icon and the text.
As for the colors, these have already been tweaked a bit to work a bit better on dark mode, but I've been too lazy to fine-tune them more. I'm not particularly great in chromatic design, so most of my stuff is just "this color looks about right"; if you have suggestions for colors I'd be happy to look into using them.

[sdgandhi]

@saagarjha I was referring to the foreground text color, sorry should have specified! I think if you went 80% opacity on all the other colors, it would look nice, but haha super subjective.

[saagarjha]

I'm using the standard system NSColor.textColor, which appears to be black in light mode and white in dark mode. This appears to be what most apps are doing as well.

Regarding the opacity of the the other colors, I'm not quite sure what you mean. All the colors are 100% opaque, but I've toned down and darkened the colors for dark mode:

Is this what you were asking?

[sdgandhi]

Yeah that looks good here, I'll try to test it too

[pouriaalmassi]

@saagarjha Great effort. Any plans to put up a PR?

[saagarjha]

I don't think what I have currently is PR-ready; it's missing some things that I'm not really able to do, either due to lack of time or resources. If anyone wants to work on this, here's a short list of what I know my version is missing:

• Improving the map view–the lines are a bit too dark
• Making sure this works on 10.8+. I have only tested this on Mojave, but @swisspol would like to maintain backwards compatibility.

I've only really touched the features I use, so there may even be parts of the app that I haven't converted that I'm unaware of. Sorry about dropping it on you guys, but hopefully someone can polish up my fork? If anyone else is working on this, I'd be happy to provide minor feedback when requested.

[MagFer]

It looks stunning! Is the last commit here https://github.com/saagarjha/GitUp/tree/mojave @saagarjha ? We should work in that, would fit very well with Xcode 10 😃💪🏼🌚!

[saagarjha]

Yeah, I've been continually amending the dark mode commit (currently at saagarjha@db45790, "Add dark mode support") as I find things that are broken/need updating. If you're interested in contributing, feel free to file issues or send in code!

[thomaspaulmann]

Any plans to get this into the next release? Looks stunning and currently GitUp stands out in my dark desktop setup :-)

[douglashill]

I took this branch as a starting point and finished off dark mode suport in my fork. Really nice for evening coding. https://github.com/douglashill/GitUp/releases

[thomaspaulmann]

Ah, so I can download your release then. Nice!

[lolgear]

@douglashill
Is there any chance that you will make a PR for it?

Thanks!

[douglashill]

I think it's unlikely such a large change would be merged, so I have no plans to make a PR.