Add support for httpCookieFile - #1251
Merged
Merged
Conversation
miya789
marked this pull request as ready for review
May 13, 2023 08:40
ldennington
reviewed
May 15, 2023
ldennington
left a comment
ldennington
left a comment
Contributor
There was a problem hiding this comment.
Looking good overall! I just added a few minor suggestions.
mjcheetham
requested changes
May 15, 2023
mjcheetham
left a comment
mjcheetham
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution here! This is great work to see :-)
I've left some comments that will need addressing before we can take the submission however, specifically around more tests for the CurlCookieParser and making it more robust to invalid or different-cased lines.
miya789
marked this pull request as draft
May 24, 2023 12:11
miya789
marked this pull request as ready for review
May 29, 2023 10:41
based on the review Co-authored-by: Lessley Dennington <ldennington@github.com> Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
based on the review Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
based on the review Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
Contributor
Author
|
I modified the code based on your review. (Sorry, I did not understand |
mjcheetham
reviewed
Jun 5, 2023
mjcheetham
left a comment
mjcheetham
left a comment
Contributor
There was a problem hiding this comment.
Great stuff @miya789! Just a few minor suggestions, and I think we will be good to merge! 🎉
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Defaults to true, but overrides even if false Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Contributor
Author
|
Thank you for comments, @mjcheetham -san! |
mjcheetham
approved these changes
Jun 6, 2023
mjcheetham
left a comment
mjcheetham
left a comment
Contributor
There was a problem hiding this comment.
This is great work @miya789! Thank you again for the contribution.
We can merge this now.
Closed
Merged
mjcheetham
added a commit
that referenced
this pull request
Jun 26, 2023
**Changes:** - Use in-proc methods for getting OS version number (#1240, #1264) - Update System.CommandLine (#1265) - Suppress GUI from command-line argument (#1267) - Add github (login|logout|list) commands (#1267) - cURL Cookie file support (#1251) - Update target framework on Mac/Linux to .NET 7 (#1274, #1282) - Replace JSON.NET with System.Text.Json (#1274) - Preserve exact redirect URI formatting in OAuth requests (#1281) - Use IP localhost redirect for GitHub (#1286) - Use WWW-Authenticate headers from Git for Azure Repos authority (#1288) - Better GitHub Enterprise Managed User (EMU) account support (#1190)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contents
#1160
I added code to support
httpCookieFile.If
httpCookieFileis set ingitconfig, gcm will add cookie header to request headers such as requests about OAuth2.Note
http.saveCookiesbecause when it is set, built-in git will update cookie and gcm need not to update.