Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System.CommandLine to latest version #1265

Merged
merged 1 commit into from
May 19, 2023

Conversation

mjcheetham
Copy link
Collaborator

Update System.CommandLine to the latest version. There have been some changes to the API since the last version around binding a command to a handler, and the removal of the model binding.

We now explicitly specify the options when setting the handlers. This means we should be able to avoid the use of reflection inside of the package, making it trimable in the future!

@mjcheetham mjcheetham added the engineering Refactoring or build changes label May 19, 2023
@mjcheetham mjcheetham requested a review from ldennington May 19, 2023 21:42
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjcheetham mjcheetham merged commit d216b53 into git-ecosystem:main May 19, 2023
@mjcheetham mjcheetham deleted the syscmdline-update branch May 19, 2023 23:13
@amireshaghian amireshaghian mentioned this pull request May 22, 2023
@mjcheetham mjcheetham mentioned this pull request Jun 26, 2023
mjcheetham added a commit that referenced this pull request Jun 26, 2023
**Changes:**

- Use in-proc methods for getting OS version number (#1240, #1264)
- Update System.CommandLine (#1265)
- Suppress GUI from command-line argument (#1267)
- Add github (login|logout|list) commands (#1267)
- cURL Cookie file support (#1251)
- Update target framework on Mac/Linux to .NET 7 (#1274, #1282)
- Replace JSON.NET with System.Text.Json (#1274)
- Preserve exact redirect URI formatting in OAuth requests (#1281)
- Use IP localhost redirect for GitHub (#1286)
- Use WWW-Authenticate headers from Git for Azure Repos authority
(#1288)
- Better GitHub Enterprise Managed User (EMU) account support (#1190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Refactoring or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants