Lazily initalise the HttpClient for the Bitbucket OAuth2ClientRegistry #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazily acquire the HttpClient instance from the factory inside of the OAuth2ClientRegistry. There is a relatively large cost to creating a new HttpClient instance (especially the first; due to config reading) that is being paid each time we just register the entire Bitbucket host provider. Whilst we are here also cleanup some of the styling/field naming in this class to be consistent with the rest of GCM.
mjcheetham
added
host:bitbucket
vdye
approved these changes
May 3, 2023
vdye
approved these changes
May 3, 2023
|
👍 |
mjcheetham
added a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily acquire the
HttpClientinstance from the factory inside of theOAuth2ClientRegistry. There is a relatively large cost to creating a newHttpClientinstance (especially the first; due to config reading) that is being paid each time we just register the entire Bitbucket host provider.Whilst we are here also cleanup some of the styling/field naming in this class to be consistent with the rest of GCM.
This saves approximately 120ms of startup time.