Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several UI bugs in 2.1 pre-release #1238

Merged
merged 4 commits into from
May 3, 2023
Merged

Fix several UI bugs in 2.1 pre-release #1238

merged 4 commits into from
May 3, 2023

Conversation

mjcheetham
Copy link
Collaborator

@mjcheetham mjcheetham commented May 3, 2023 •
edited
Loading

Fix a few bugs that were spotted during testing of the 2.1 pre-release:

  • Missing Atlassian logo resource from the compiled binaries
  • Remote URL is shown even for Bitbucket cloud with in-proc GUI
  • In-proc basic auth GUI user name field should only be set if non-null or whitespace

Also bump the VERSION to 2.1.1 in the expectation for this to replace 2.1.0.

mjcheetham added 3 commits May 3, 2023 11:04
@mjcheetham
bitbucket: include Atlassian logo resource
01eca12 
Make sure to include the Atlassian logo as an AvaloniaResource so it's
included in the compiled binaries.
@mjcheetham
bitbucket: only show URL if not Bitbucket Cloud
ba76ac9 
Only show the URL if the remote is NOT Bitbucket Cloud in the in-proc
UI. This is same behaviour as the helper UI.
@mjcheetham
basic-auth: only set username if not-null
1eb8682
@mjcheetham mjcheetham added bug A bug in Git Credential Manager gui Specific to graphical user interface controls labels May 3, 2023
@mjcheetham mjcheetham requested a review from ldennington May 3, 2023 18:13
ldennington
ldennington approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! 🌟

@mjcheetham mjcheetham merged commit 7667f6a into git-ecosystem:main May 3, 2023
@mjcheetham mjcheetham deleted the ui-fixes branch May 3, 2023 18:42
@mjcheetham mjcheetham mentioned this pull request May 8, 2023
Merged
mjcheetham added a commit that referenced this pull request May 8, 2023
@mjcheetham
Hotfix release GCM 2.1.1 (#1244)
ca22bd8 
**Changes since 2.1.0:**

- Fix several UI bugs (#1238, #1241)
- Lazily initialise Bitbucket host provider dependencies (#1239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldennington ldennington ldennington approved these changes

Assignees
No one assigned
Labels
bug A bug in Git Credential Manager gui Specific to graphical user interface controls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcheetham @ldennington