add custom Delims support #860
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #860 +/- ##
===========================================
+ Coverage 93.49% 93.95% +0.46%
===========================================
Files 16 16
Lines 1353 1357 +4
===========================================
+ Hits 1265 1275 +10
+ Misses 78 68 -10
- Partials 10 14 +4
Continue to review full report at Codecov.
|
|
Wrong branch and missing testing. |
|
@appleboy How can I do for this PR? |
|
@saser I changed the base branch. You just add testing code on your branch and push commits. |
|
@appleboy Need I add testing code on the master branch , then push commits ? Or others? |
|
@shenshouer Push your commits in your |
gin.go
Outdated
| func (engine *Engine) LoadHTMLGlob(pattern string) { | ||
| if IsDebugging() { | ||
| debugPrintLoadTemplate(template.Must(template.ParseGlob(pattern))) | ||
| engine.HTMLRender = render.HTMLDebug{Glob: pattern} | ||
| // debugPrintLoadTemplate(template.Must(template.ParseGlob(pattern))) |
There was a problem hiding this comment.
No need for this comments code
There was a problem hiding this comment.
@shenshouer Please remove this comments.
gin_test.go
Outdated
| @@ -8,11 +8,60 @@ import ( | |||
| "reflect" | |||
| "testing" | |||
|
|
|||
| "net/http" | |||
|
|
|||
There was a problem hiding this comment.
Why all these blank lines?
There was a problem hiding this comment.
Sorry for the miss inspection, this was auto import package and format style by the vscode.
There was a problem hiding this comment.
please remove the empty line for import native package.
|
@tboerger Please review again. |
|
Looks like the commits ate messed up, you need to rebase properly. |
|
@tboerger no. It doesn't matter about previous commits. We can squash and merge this PR. |
|
How can we get this merged? |
|
@shenshouer Thanks for your contribution. |
add custom delims support, for example: