Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #752 ignore appengine os. #753

Merged
merged 1 commit into from
Dec 3, 2016
Merged

fix #752 ignore appengine os. #753

merged 1 commit into from
Dec 3, 2016

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Dec 3, 2016 •
edited
Loading

critical issue #752

Please help to review.

cc @javierprovecho @tboerger

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

@appleboy
fix #752 ignore appengine os.
b26d956 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@tboerger
Copy link
Contributor

tboerger commented Dec 3, 2016

And why do you also ignore bsd?

@javierprovecho
Copy link
Member

@tboerger https://github.com/golang/crypto/blob/master/ssh/terminal/util.go#L5 build tags

@javierprovecho javierprovecho merged commit 556287f into master Dec 3, 2016
@vermotr
Copy link

vermotr commented Dec 3, 2016 •
edited
Loading

I also use Google App Engine and I have the same issue #752 than @kujenga:

go-app-builder: Failed parsing input: parser: bad import "syscall" in golang.org/x/crypto/ssh/terminal/terminal.go from GOPATH

I have temporarily fixed it by checking out the bb159f9 commit, but can you try to fix this problem?

javierprovecho added a commit that referenced this pull request Dec 3, 2016
@javierprovecho
Revert "Merge pull request #753 from gin-gonic/bug"
63b5d1c 
This reverts commit 556287f, reversing
changes made to 32cab50.
@javierprovecho
Copy link
Member

@vermotr sorry, master from github and gopkg mirror is now stable at v1.1.3, with both this and #744 reverted on master. We'll keep working on this feature in develop

@vermotr
Copy link

vermotr commented Dec 3, 2016

@javierprovecho No worries, thanks a lot for the fix!

@appleboy appleboy deleted the bug branch December 4, 2016 00:27
@appleboy appleboy mentioned this pull request Dec 4, 2016
Merged
@appleboy
Copy link
Member Author

appleboy commented Dec 4, 2016 •
edited
Loading

@vermotr I make new PR to ignore Google App Engine os type. Please help to test again #754.

appleboy pushed a commit that referenced this pull request Feb 1, 2017
@appleboy
Update gin version (#790)
049da60 
* Revert "Merge pull request #753 from gin-gonic/bug"

This reverts commit 556287f, reversing
changes made to 32cab50.

* Revert "Merge pull request #744 from aviddiviner/logger-fix"

This reverts commit c3bfd69, reversing
changes made to 9177f01.

* Update gin version
appleboy pushed a commit that referenced this pull request May 29, 2017
@shenshouer @appleboy
add custom Delims support (#860)
35f5df6 
* Revert "Merge pull request #753 from gin-gonic/bug"

This reverts commit 556287f, reversing
changes made to 32cab50.

* Revert "Merge pull request #744 from aviddiviner/logger-fix"

This reverts commit c3bfd69, reversing
changes made to 9177f01.

* add custom Delims support

* add some test for Delims

* remove the empty line for import native package

* remove unuseful comments
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@appleboy appleboy

@javierprovecho javierprovecho

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@appleboy @tboerger @javierprovecho @vermotr