fallback Context.Deadline() Context.Done() Context.Err() to Context.Request.Context() #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2769 +/- ##
==========================================
+ Coverage 98.70% 98.71% +0.01%
==========================================
Files 41 41
Lines 2077 2100 +23
==========================================
+ Hits 2050 2073 +23
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
appleboy
previously approved these changes
Jul 5, 2021
kszafran
reviewed
Jul 30, 2021
appleboy
approved these changes
Jul 31, 2021
daheige
pushed a commit
to daheige/gin
that referenced
this pull request
Apr 18, 2022
…equest.Context() (gin-gonic#2769) * fallback Context.Deadline() Context.Done() Context.Err() to Context.Request.Context() * update comments wording
|
It seems that this PR is breaking change in regard of how works gin v1.7 (#3166) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base on comment #2751 (comment) in #2751
also fallback Context.Deadline() Context.Done() Context.Err() to Context.Request.Context()