gin.Context with fallback value from gin.Context.Request.Context()

[wei840222]

For many tracing sdk
They will have SpanFromContext function. like:
https://github.com/opentracing/opentracing-go/blob/master/gocontext.go#L26
https://github.com/open-telemetry/opentelemetry-go/blob/main/trace/context.go#L48

And middleware sdk always put trace contenxt to http.Request.Context
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/github.com/gin-gonic/gin/otelgin/gintrace.go#L79

If gin.Context with fallback value from gin.Context.Request.Context(), it can be pass the gin.Context as context.Context to sub function call. It will be usefull.

user, err := h.GetUser(c.Request.Context(), userID)

can be

user, err := h.GetUser(c, userID)

[thinkgos]

Good!! I always use c.Request.Context().

[appleboy]

@wei840222 Please rebase the master branch to trigger unit testing with GitHub Actions.

[wei840222]

hi @appleboy. I've rebased the master, plz check.

[codecov]

Codecov Report

Merging #2751 (e62a357) into master (34ce210) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2751   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files          41       41           
  Lines        2072     2079    +7     
=======================================
+ Hits         2045     2052    +7     
  Misses         15       15           
  Partials       12       12           

Impacted Files	Coverage Δ
context.go	97.69% <100.00%> (+0.03%)	⬆️
gin.go	99.18% <100.00%> (ø)
tree.go	100.00% <100.00%> (ø)
recovery.go	97.22% <0.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ce210...e62a357. Read the comment docs.

[thinkerou]

lgtm

[thinkgos]

@wei840222 @appleboy @thinkerou This may be break change, I always use c.Request.Context(), It can be cancel or timeout when I use middleware. We should Done() and Deadline(),Err() API fallback c.Request.Done(), c.Request.Deadline(),c.Request.Err() too ?

[wei840222]

This proposal is good, for the default impl in Context.Deadline() Context.Done() Context.Err() seems no actual behavior.
This seems to increase the ease of use.
Maybe I can add this in another pr ?

[thinkerou]

This proposal is good, for the default impl in Context.Deadline() Context.Done() Context.Err() seems no actual behavior.
This seems to increase the ease of use.
Maybe I can add this in another pr ?

please, thanks!

[pavelpatrin]

Still not in any release? Maybe release as a 1.7.8?

[jerome-laforge]

@wei840222 @appleboy @thinkerou This may be break change, I always use c.Request.Context(), It can be cancel or timeout when I use middleware. We should Done() and Deadline(),Err() API fallback c.Request.Done(), c.Request.Deadline(),c.Request.Err() too ?

As said by @thinkgos, this change makes a break change #3166