v1.4.0 + #1631 (remove go1.6/go1,7 support) #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
+ Coverage 98.65% 98.74% +0.08%
==========================================
Files 41 38 -3
Lines 2149 2143 -6
==========================================
- Hits 2120 2116 -4
+ Misses 18 15 -3
- Partials 11 12 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
@appleboy @thinkerou I heard a rumor you guys might be able to do releases now. Can I do anything to make this PR more helpful to push this over the finish line! |
Closed
Member
|
@dmarkham I have permission to create new tag now. I will review the PR asap |
appleboy
reviewed
May 7, 2019
| if values := req.MultipartForm.Value[key]; len(values) > 0 { | ||
| return values, true | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Add this code for support go1.6, please commit message: 51386de
appleboy
reviewed
May 7, 2019
|
|
||
| if !exist && req.MultipartForm != nil && req.MultipartForm.File != nil { | ||
| dicts, exist = c.get(req.MultipartForm.Value, key) | ||
| } |
Member
There was a problem hiding this comment.
Add this code for support go1.6, please commit message: 51386de
appleboy
approved these changes
May 7, 2019
thinkerou
approved these changes
May 7, 2019
Contributor
Author
|
🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a starting point for the
v1.4.0release issue #1732.This also merges in #1631 after fixing the conflicts.