Skip to content

Remove go1.6/go1.7 support #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Remove go1.6/go1.7 support #1631

wants to merge 19 commits into from

Conversation

@thinkerou
Copy link
Member

@thinkerou thinkerou commented Nov 7, 2018 •
edited
Loading

closing #1381

@codecov
Copy link

codecov bot commented Nov 7, 2018 •
edited
Loading

Codecov Report

Merging #1631 into master will increase coverage by 0.08%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   98.64%   98.73%   +0.08%     
==========================================
  Files          41       38       -3     
  Lines        2146     2140       -6     
==========================================
- Hits         2117     2113       -4     
+ Misses         18       15       -3     
- Partials       11       12       +1
Impacted Files Coverage Δ
debug.go 95.91% <100%> (ø) ⬆️
render/redirect.go 100% <100%> (ø) ⬆️
context.go 98.36% <100%> (-0.02%) ⬇️
render/json.go 87.65% <100%> (+1.16%) ⬆️
response_writer.go 95.23% <50%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1f3c4...7a2b89b. Read the comment docs.

@appleboy appleboy added this to the 1.4 milestone Nov 8, 2018
@thinkerou thinkerou changed the title Remove go1.6 support Remove go1.6/go1.7 support Nov 20, 2018
@thinkerou thinkerou self-assigned this Dec 12, 2018
@thinkerou thinkerou modified the milestones: 1.4, 1.x Dec 13, 2018
appleboy
appleboy reviewed Dec 19, 2018
View reviewed changes
@thinkerou
Copy link
Member Author

thinkerou commented Dec 19, 2018 •
edited
Loading

The COV drop was caused by some code only used on go1.6/1.7, maybe we should find and remove it.

Update: done!

thinkerou
thinkerou commented Dec 19, 2018
View reviewed changes
@thinkerou
Copy link
Member Author

thinkerou commented Feb 18, 2019 •
edited
Loading

@javierprovecho @appleboy we need to remove go1.6/1.7 support at gin1.4 version now? thanks!

@thinkerou thinkerou modified the milestones: 1.x, 1.5 Feb 26, 2019
@thinkerou thinkerou mentioned this pull request Mar 1, 2019
Merged
6 tasks
@thinkerou
Copy link
Member Author

thinkerou commented Mar 7, 2019

I add unit test for http2 pusher, but seem invalid, I don't know why.

@thinkerou thinkerou mentioned this pull request Mar 19, 2019
Merged
@thinkerou
Copy link
Member Author

thinkerou commented Mar 19, 2019

Hi @appleboy the pull request need to merge to gin1.4 release version? thanks!

@thinkerou thinkerou mentioned this pull request Mar 25, 2019
Closed
@thinkerou thinkerou mentioned this pull request Apr 4, 2019
Closed
@dmarkham dmarkham mentioned this pull request Apr 7, 2019
Merged
@thinkerou
Copy link
Member Author

thinkerou commented May 7, 2019

see #1851

@thinkerou thinkerou closed this May 7, 2019
thinkerou pushed a commit that referenced this pull request May 7, 2019
@dmarkham @thinkerou
v1.4.0 + #1631 (remove go1.6/go1,7 support) (#1851)
094f9a9 
* remove go1.6 support

* remove build tag

* remove todo

* remove go1.6 support: https://github.com/gin-gonic/gin/pull/1383/commits

* update readme

* remove go1.7 support

* fix embedmd error

* test

* revert it

* revert it

* remove context_17

* add pusher test

* v1.4.0 rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy appleboy left review comments

@javierprovecho javierprovecho Awaiting requested review from javierprovecho

Assignees

@thinkerou thinkerou

Labels

enhancement

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkerou @appleboy