Skip to content

Conversation

@dmarkham
Copy link
Contributor

@dmarkham dmarkham commented Apr 4, 2019

I'm aware removing go1.6/go1.7 was scheduled for v1.5.0 but given the amount of time that has passed we now have go1.12 so supporting only go1.9+ is older than go supports.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #1843 into master will increase coverage by 0.08%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1843      +/-   ##
==========================================
+ Coverage   98.64%   98.73%   +0.08%     
==========================================
  Files          41       38       -3     
  Lines        2144     2138       -6     
==========================================
- Hits         2115     2111       -4     
+ Misses         18       15       -3     
- Partials       11       12       +1
Impacted Files Coverage Δ
debug.go 95.91% <100%> (ø) ⬆️
render/redirect.go 100% <100%> (ø) ⬆️
context.go 98.36% <100%> (-0.02%) ⬇️
render/json.go 87.65% <100%> (+1.16%) ⬆️
response_writer.go 95.23% <50%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e915f4...e0e697f. Read the comment docs.

@thinkerou
Copy link
Member

please see #1631 thanks!

@dmarkham dmarkham closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants