Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP status code is illegible #1552

Closed
BrandonZacharie opened this issue Sep 15, 2018 · 1 comment
Closed

HTTP status code is illegible #1552

BrandonZacharie opened this issue Sep 15, 2018 · 1 comment

Comments

@BrandonZacharie
Copy link

  • go version: go1.11 darwin/amd64
  • gin version (or commit ref): v1.3.0
  • operating system: macOS High Sierra

Description

White text on a yellow background is completely illegible... I can think of three different ways to solve this; make the text color darker, keep the text white and make the background darker, or add support for configuring the text and/or background color.

Screenshots

screen shot 2018-09-15 at 13 53 03

@thinkerou
Copy link
Member

Hi, @BrandonZacharie please help me see #1547 and so I need to ensure it and then attempt to fix this. thanks!

thinkerou pushed a commit that referenced this issue Sep 26, 2018
#1570)

1. Why is this change neccesary?
White text on a yellow background was illegible with most terminal color schemes

2. How does it address the issue?
The white text was replaced with a bash compatible dark gray while keeping the
yellow background colour

3. What side effects does this change have?
Resolves #1552
justinfx pushed a commit to justinfx/gin that referenced this issue Nov 3, 2018
gin-gonic#1570)

1. Why is this change neccesary?
White text on a yellow background was illegible with most terminal color schemes

2. How does it address the issue?
The white text was replaced with a bash compatible dark gray while keeping the
yellow background colour

3. What side effects does this change have?
Resolves gin-gonic#1552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants