Make logger use a yellow background and a darkgray text for legibility #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Why is this change neccesary? White text on a yellow background was illegible with most terminal color schemes 2. How does it address the issue? The white text was replaced with a bash compatible dark gray while keeping the yellow background colour 3. What side effects does this change have? Resolves #1552
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 39 39
Lines 1922 1922
=======================================
Hits 1904 1904
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
appleboy
approved these changes
Sep 26, 2018
justinfx
pushed a commit
to justinfx/gin
that referenced
this pull request
Nov 3, 2018
gin-gonic#1570) 1. Why is this change neccesary? White text on a yellow background was illegible with most terminal color schemes 2. How does it address the issue? The white text was replaced with a bash compatible dark gray while keeping the yellow background colour 3. What side effects does this change have? Resolves gin-gonic#1552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change neccesary?
White text on a yellow background was illegible with most terminal color schemes
How does it address the issue?
The white text was replaced with a bash compatible dark gray while keeping the
yellow background colour
What side effects does this change have?
Resolves HTTP status code is illegible #1552
Before:
After:
