Skip to content

Commit

Permalink
Integrate arethetypeswrong (connectrpc#184)
Browse files Browse the repository at this point in the history
Fixes connectrpc#182 

This integrates the `arethetypeswrong` CLI to the codebase and runs it
in CI, fixing any type issues that existed.

---------

Co-authored-by: Timo Stamm <ts@timostamm.de>
  • Loading branch information
smaye81 and timostamm authored Sep 29, 2023
1 parent ee30d41 commit ee980be
Show file tree
Hide file tree
Showing 6 changed files with 173 additions and 19 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,8 @@ jobs:
- name: Install dependencies
run: pnpm install

- name: Build
run: pnpm run build

- name: Generate
run: pnpm run generate

- name: Lint
run: pnpm run format

- name: Test
run: pnpm run test
- name: Run CI
run: pnpm run all

- name: Check changed files
id: check_changed_files
Expand Down
1 change: 1 addition & 0 deletions cspell.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"Timo",
"Vindaloo",
"Weizenbaum's",
"attw",
"backoffs",
"bufbuild",
"codegen",
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
"generate": "turbo run generate",
"test": "turbo run test",
"format": "pnpm run format:root && turbo run format",
"attw": "turbo run attw",
"check:spelling": "cspell \"**\" --gitignore",
"all": "turbo run build generate format test",
"all": "turbo run build generate format attw test",
"update-all": "pnpm update --recursive --latest",
"format:root": "pnpm run check:spelling && prettier \"*.js\" \"*.ts\" \"README.md\" --write --no-error-on-unmatched-pattern"
},
Expand Down
12 changes: 6 additions & 6 deletions packages/connect-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,12 @@
"type": "module",
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.cjs"
"module": "./dist/index.js",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
}
},
"main": "./dist/index.cjs",
"module": "./dist/index.js",
"types": "./dist/index.d.ts",
"files": [
"dist/**"
],
Expand All @@ -27,12 +25,14 @@
"clean": "rm -rf dist",
"generate": "buf generate --path eliza.proto",
"test": "jest",
"format": "prettier . --write --ignore-path ./.eslintignore && eslint . --fix && license-header"
"format": "prettier . --write --ignore-path ./.eslintignore && eslint . --fix && license-header",
"attw": "attw --pack"
},
"dependencies": {
"stable-hash": "^0.0.3"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.11.0",
"@bufbuild/buf": "1.26.1",
"@bufbuild/jest-environment-jsdom": "^0.1.1",
"@bufbuild/protobuf": "^1.3.1",
Expand Down
160 changes: 159 additions & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"dependsOn": ["generate"],
"cache": false
},
"attw": {
"dependsOn": ["build"]
},
"format": {
"dependsOn": ["generate"]
}
Expand Down

0 comments on commit ee980be

Please sign in to comment.