Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify our exports with arethetypeswrong #182

Closed
timostamm opened this issue Sep 29, 2023 · 0 comments · Fixed by #184
Closed

Verify our exports with arethetypeswrong #182

timostamm opened this issue Sep 29, 2023 · 0 comments · Fixed by #184
Assignees
@smaye81

Comments

@timostamm
Copy link
Member

https://arethetypeswrong.github.io/ verifies type exports of NPM packages with the version resolution algorithms implemented in TypeScript.

It's available as a CLI, and we should use it here to guard against regressions. For reference, see connectrpc/connect-es#838.
@smaye81 smaye81 mentioned this issue Sep 29, 2023
Merged
smaye81 added a commit that referenced this issue Sep 29, 2023
@smaye81 @timostamm
Integrate arethetypeswrong (#184)
ee980be 
Fixes #182 

This integrates the `arethetypeswrong` CLI to the codebase and runs it
in CI, fixing any type issues that existed.

---------

Co-authored-by: Timo Stamm <ts@timostamm.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smaye81 smaye81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate arethetypeswrong connectrpc/connect-query-es
2 participants
@smaye81 @timostamm