Fetches the latest upstream #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nose hasn't seen a release since 2015 and sadly doesn't work with Python 3.10. See nose-devs/nose#1099
This stops using not as a function and hopefully also makes the logic clearer.
Update checkout to v3 (no relevant changes) and setup-python to v4 (changes the names for pypy versions).
We have some long URLs in the code (mostly in docstrings) and wrapping them does not improve readability (and is difficult in docstrings) so the E501 ignore is now put inside each file instead of globally. Closes arthurdejong/python-stdnum#302
Improper inflection of plurals. Closes arthurdejong/python-stdnum#299
Charlottenburg (Berlin) is a valid court representation for Berlin (Charlottenburg). See https://www.northdata.com/VRB+Service+GmbH,+Berlin/Amtsgericht+Charlottenburg+%28Berlin%29+HRB+103587+B Closes arthurdejong/python-stdnum#298
This also switches the other Tox jobs to use the latest Python 3.x interpreter. Closes arthurdejong/python-stdnum#305
The page currently lists a country without a country code (is listed as "-"). This also ensures that lists of country codes are handled consistently.
The number used before was apparently no longer valid.
This currently only checks the length and whether it only contains digits because little could be found on the structure of the number of whether there are any check digits. Closes arthurdejong/python-stdnum#313 Closes arthurdejong/python-stdnum#307
Note that this is implementation is mostly based on unofficial sources describing the format, which match the hundreds of examples found online. https://forum.it.mk/threads/modularna-kontrola-na-embg-edb-dbs-itn.15663/?__cf_chl_tk=Op2PaEIauip6Z.ZjvhP897O8gRVAwe5CDAVTpjx1sEo-1663498930-0-gaNycGzNCRE#post-187048 Also note that the algorithm for the check digit was tested on all found examples, and it doesn't work for all of them, despite those failing examples don't seem to be valid according to the official online search. Closes arthurdejong/python-stdnum#330 Closes arthurdejong/python-stdnum#222
This also applies the fix from cfc80c8 from Python 2.7 to PyPy.
The Indonesian NPWP is being switched from 15 to 16 digits. The number is now the NIK for Indonesian citizens and the old format with a leading 0 for others (organisations and non-citizens). See https://www.grantthornton.co.id/insights/global-insights1/updates-regarding-the-format-of-indonesian-tax-id-numbers/ Closes arthurdejong/python-stdnum#432
Use the inspect.signature() function instead. The inspect.getargspec() function was removed in Python 3.11.
The timeout parameter of the zeep transport class is not responsable for POST/GET timeouts. The operational_timeout parameter should be used for that. See mvantellingen/python-zeep#140 Closes arthurdejong/python-stdnum#444 Closes arthurdejong/python-stdnum#445
This adds a `verify` argument to all functions that use network services for lookups. The option is used to configure how certificate validation works, the same as in the requests library. For SOAP requests this is implemented properly when using the Zeep library. The implementations using Suds and PySimpleSOAP have been updated on a best-effort basis but their use has been deprecated because they do not seem to work in practice in a lot of cases already. Related to arthurdejong/python-stdnum#452 Related to arthurdejong/python-stdnum#453
This fixes the get_soap_client() function to cache SOAP clients taking the verify argument into account. Fixes 3fcebb2
This silences a ton of ast deprecation warnings that we can't fix in python-stdnum anyway.
This deprecates the stdnum.util.to_unicode() function because we no longer have to deal with bytestrings.
It seems that numbers with a format used for juridical RUCs have been issued to companies. Closes arthurdejong/python-stdnum#457
It seems that a small minority of numbers assigned with a checksum of 10 are still valid and expected to have a check digit value of 0. According to https://www.domzo13.cz/sw/evok/help/born_numbers.html this practice even happended (but less frequently) after 1985. Closes arthurdejong/python-stdnum#468
There was a change in the SOAP service and there is a new URL. However, the API has changed and seems to require authentication. We ignore test failures for now but unless a solution is found the DGII validation will be removed. See: arthurdejong/python-stdnum#462 See: arthurdejong/python-stdnum#461
gustav
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.