Repository navigation
fix(chart): take every key the agent-platform meta chart forwards - #21
Merged
Merged
Conversation
3 tasks
Published Helm chart
|
| Chart | workspace-manager |
| Version | 0.0.0-rfc925ee6t20261010030327h104a97a |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/workspace-manager:0.0.0-rfc925ee6t20261010030327h104a97a |
| Digest | sha256:16490059e804c681d55f4c4220ea978a92399658f4ab7161248ca0b52c910b0a |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/workspace-manager --version 0.0.0-rfc925ee6t20261010030327h104a97aPosted by architect-orb · build 387 · commit 104a97a · updated in place on every push
This was referenced Oct 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chart's strict values schema refused the keys the agent-platform meta chart forwards to this release (
grant.signingKey,sync.cycle,sessions.cleanupAfter,storage.sizing.factor,.headroom,.maxSize), so the release failed schema validation the moment an installation set any of them.Solution
Every forwarded key is a key of this chart, declared in
values.yamlwith its meaning (so the generated schema carries it) and passed toserveas a flag the start validates:grant.signingKey{name, key}--grant-signing-key=<secret>/<key>sync.cycle--sync-cycle10msessions.cleanupAfter--sessions-cleanup-after720hstorage.sizing.factor--sizing-factor1.5storage.sizing.headroom--sizing-headroom5Gispec.sizing.headroomreplaces it)storage.sizing.maxSize--sizing-max-sizeThe sign-in store's key already exists as
signin.keys.secretName/signin.keys.currentand keeps that name; the meta chart'ssignInStore.encryptionKeyforward moves to it in the agent-platform follow-up. One comment line invalues.yamlthat the schema generator dropped (it contained a double dash) is reworded, so its description is whole again.Proof
tests/forwarded_test.yamlrenders the meta chart's forwarded block (its workspaces fixture,storage.storageClassNameand every optional key) against the schema and asserts each flag; it also proves an undeclared key (signInStore) and a non-numeric factor are refused.make helm-test(55 tests),go test ./...andpre-commit run --all-filespass.Closes #19