Skip to content

fix(chart): take every key the agent-platform meta chart forwards - #21

Merged
teemow merged 2 commits into
mainfrom
fix/forwarded-keys
Oct 10, 2026
Merged

teemow merged 2 commits into
mainfrom
fix/forwarded-keys

Conversation

@teemow

@teemow teemow commented Oct 10, 2026

Copy link
Copy Markdown
Member

Problem

The chart's strict values schema refused the keys the agent-platform meta chart forwards to this release (grant.signingKey, sync.cycle, sessions.cleanupAfter, storage.sizing.factor, .headroom, .maxSize), so the release failed schema validation the moment an installation set any of them.

Solution

Every forwarded key is a key of this chart, declared in values.yaml with its meaning (so the generated schema carries it) and passed to serve as a flag the start validates:

Value Flag Default Consumed
grant.signingKey {name, key} --grant-signing-key=<secret>/<key> none read at start with providers and OAuth; a missing entry or a key under 32 bytes fails the start
sync.cycle --sync-cycle 10m the controller's reconcile period
sessions.cleanupAfter --sessions-cleanup-after 720h the controller's session-directory cleanup window
storage.sizing.factor --sizing-factor 1.5 new claim size = measured need × factor
storage.sizing.headroom --sizing-headroom 5Gi + headroom (a Workspace's larger spec.sizing.headroom replaces it)
storage.sizing.maxSize --sizing-max-size none ceiling, wins over the spec's minimum

The sign-in store's key already exists as signin.keys.secretName / signin.keys.current and keeps that name; the meta chart's signInStore.encryptionKey forward moves to it in the agent-platform follow-up. One comment line in values.yaml that the schema generator dropped (it contained a double dash) is reworded, so its description is whole again.

Proof

  • tests/forwarded_test.yaml renders the meta chart's forwarded block (its workspaces fixture, storage.storageClassName and every optional key) against the schema and asserts each flag; it also proves an undeclared key (signInStore) and a non-numeric factor are refused.
  • Unit tests for the sizing rule, its validation, the flag defaults and environment variables, the flag validation and the grant key check.
  • make helm-test (55 tests), go test ./... and pre-commit run --all-files pass.

Closes #19

@circleci-architect

circleci-architect Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Published Helm chart workspace-manager

0.0.0-rfc925ee6t20261010030327h104a97a
Chart workspace-manager
Version 0.0.0-rfc925ee6t20261010030327h104a97a
OCI reference oci://gsoci.azurecr.io/charts/giantswarm/workspace-manager:0.0.0-rfc925ee6t20261010030327h104a97a
Digest sha256:16490059e804c681d55f4c4220ea978a92399658f4ab7161248ca0b52c910b0a
Registry public — gsoci.azurecr.io
Git catalog giantswarm-test-catalog (index)
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/workspace-manager --version 0.0.0-rfc925ee6t20261010030327h104a97a

Posted by architect-orb · build 387 · commit 104a97a · updated in place on every push

@teemow
teemow merged commit b6de904 into main Oct 10, 2026
12 checks passed
@teemow
teemow deleted the fix/forwarded-keys branch October 10, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(chart): the values schema refuses the keys the agent-platform meta chart forwards

1 participant