Repository navigation
feat(workspaces): forward the StorageClass to workspace-manager rc.13 - #909
Merged
Merged
Conversation
Published Helm chart
|
| Chart | agent-platform-connectivity |
| Version | 4.123.1-r7e3305f6t20261010035556hd35fd95 |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/agent-platform-connectivity:4.123.1-r7e3305f6t20261010035556hd35fd95 |
| Digest | sha256:cff630f2a64a08aff2dc464485887f15d63260c62106f617561d590936d540a6 |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent-platform-connectivity --version 4.123.1-r7e3305f6t20261010035556hd35fd95Posted by architect-orb · build 20916 · commit d35fd95 · updated in place on every push
Published Helm chart
|
| Chart | agent-platform |
| Version | 4.123.1-r7e3305f6t20261010035556hd35fd95 |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/agent-platform:4.123.1-r7e3305f6t20261010035556hd35fd95 |
| Digest | sha256:48440f147753e814159adc846e8eeea473533f3b7236bfce23c4f9ccf7f68632 |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent-platform --version 4.123.1-r7e3305f6t20261010035556hd35fd95Posted by architect-orb · build 20915 · commit d35fd95 · updated in place on every push
Member
Author
|
Lab proof (written by an agent): the PR's chart installed from the working tree on a local kind lab with workspaces on and
|
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The follow-up #906 announced: with workspaces on,
workspaces.storage.storageClassNamereached the connectivity release but not the workspace-manager release, because the floor (>=0.1.0-rc.10) has a closed schema that refusesstorage. Two more mismatches with the workspace-manager chart (giantswarm/workspace-manager#19): the meta chart declared aworkspace-manager.signInStore.encryptionKeythe chart has never taken (its sign-in keys aresignin.keys {secretName, current}, forwarded since #907), and thesync.cyclecomment called it the mirror fetch interval, while it is the controller's reconcile period.Proposed solution
components.workspace-manager.versionRangeis>=0.1.0-rc.13 <1.0.0: rc.13 (fix(chart): take every key the agent-platform meta chart forwards workspace-manager#21) is the first release whose schema declares every key the meta chart forwards. The BOM pins 0.1.0-rc.13.workspace-manager.storage.storageClassNamefromworkspaces.storage.storageClassName(componentDerivedValues, next toworkspaces.namespace); an own value that disagrees fails the render naming the key.workspace-manager.signInStoreis removed from values andomitEmptyKeys; asignInStoreblock fails the render namingsignin.keys. Every other forwarded key (oauth,muster.mcpServer,signin.keys,providers,grant.signingKey,sync.cycle,sessions.cleanupAfter,storage.*,serviceMonitor,observability.otel,workspaces.namespace) is declared by rc.13 under that name.sync.cyclecomment and README: the reconcile period (default10m), not the fetch interval; each Workspace'sspec.syncdecides when mirrors are fetched.verify-workspace-manager(the class forwarded,signInStorerefused, 5 credentials),verify-workspace-storage(the forward and the disagreement guard); CHANGELOG.The README edits overlap #895 (README rewrite) on a few lines of the Workspaces section, as #906 and #907 did; whichever merges second merges main.
Acceptance criteria
make verify-workspace-manager verify-workspace-storage verify-workspace-manager-routepass.make verify-components-chartsrenders workspace-manager 0.1.0-rc.13 with the forwarded block (the class included) in every shape.storage.storageClassNameset from the chart path, the workspace-manager HelmRelease is Ready on rc.13 withstorage.storageClassNamein its values.The remainder of giantswarm/workspace-manager#18.