Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py : fix requirements check '==' -> '~=' #8982

Merged
merged 3 commits into from
Aug 12, 2024
Merged

py : fix requirements check '==' -> '~=' #8982

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eaf614
py : fix requirements check '==' -> '~='
ggerganov Aug 11, 2024
5b2717c
cont : fix the fix
ggerganov Aug 11, 2024
bfebb38
ci : run on all requirements.txt
ggerganov Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/llava/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
--extra-index-url https://download.pytorch.org/whl/cpu
pillow~=10.2.0
torch~=2.2.1
torchvision==0.17.1
torchvision!=0.17.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? I don't know what that syntax does in pip but it seems like it should be ~= instead.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, it was a mistake

Loading