py : fix requirements check '==' -> '~='

[ggerganov]

ref #7599 (comment)

• I have read the contributing guidelines
• Self-reported review complexity:
  • Low
  • Medium
  • High

[JohannesGaessler]

Is this intentional? I don't know what that syntax does in pip but it seems like it should be ~= instead.

[ggerganov]

Thanks for catching this, it was a mistake

[compilade]

It seems like the check-requirements.sh CI check doesn't run on all requirements.txt changes like this one (which was also why the problem was introduced).

Maybe using the same glob pattern as in check-requirements.sh could help?

llama.cpp/scripts/check-requirements.sh

Line 142 in 8cd1bcf

for req in */**/requirements*.txt; do

(and adapting it to conform to GitHub's file path pattern syntax)

diff --git a/.github/workflows/python-check-requirements.yml b/.github/workflows/python-check-requirements.yml
index 4e0374fc..46e80aec 100644
--- a/.github/workflows/python-check-requirements.yml
+++ b/.github/workflows/python-check-requirements.yml
@@ -6,15 +6,13 @@ on:
       - '.github/workflows/python-check-requirements.yml'
       - 'scripts/check-requirements.sh'
       - 'convert*.py'
-      - 'requirements.txt'
-      - 'requirements/*.txt'
+      - '**/requirements*.txt'
   pull_request:
     paths:
       - '.github/workflows/python-check-requirements.yml'
       - 'scripts/check-requirements.sh'
       - 'convert*.py'
-      - 'requirements.txt'
-      - 'requirements/*.txt'
+      - '**/requirements*.txt'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}